Skip to content

Adds ProcTimeBeforeFlush function to BlockChain #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 22, 2025

Conversation

diegoximenes
Copy link
Contributor

@diegoximenes diegoximenes commented May 20, 2025

Related to NIT-3231 and NIT-3232

Adds ProcTimeBeforeFlush function to BlockChain.

Pulled by OffchainLabs/nitro#3253

@diegoximenes diegoximenes force-pushed the trie_time_before_flush branch from 20c26de to b3e7b8b Compare May 20, 2025 17:18
@diegoximenes diegoximenes marked this pull request as ready for review May 20, 2025 19:02
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added one nitpick comment for the method name

@diegoximenes diegoximenes requested a review from magicxyyz May 22, 2025 13:14
@diegoximenes diegoximenes changed the title Adds TimeBeforeFlush function to BlockChain Adds ProcTimeBeforeFlush function to BlockChain May 22, 2025
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljobe
Copy link
Member

eljobe commented May 23, 2025

Just assigning this to @diegoximenes until the corresponding nitro PR has had the review comments addressed.

@tsahee tsahee enabled auto-merge July 22, 2025 22:15
@tsahee tsahee merged commit 1a03a77 into master Jul 22, 2025
14 checks passed
@tsahee tsahee deleted the trie_time_before_flush branch July 22, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants